Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom status and latency display #98

Merged
merged 4 commits into from
Mar 31, 2024
Merged

feat: custom status and latency display #98

merged 4 commits into from
Mar 31, 2024

Conversation

Mantouisyummy
Copy link
Collaborator

🚀feat: custom status and latency display

@Mantouisyummy Mantouisyummy linked an issue Feb 13, 2024 that may be closed by this pull request
feat: custom status and latency display #26
Closed
@github-actions GitHub Actions
Copy link

Qodana Community for Python

2 new problems were found

Inspection name Severity Problems
Unsatisfied package requirements 🔶 Warning 1
PEP 8 coding style violation ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@wolf-yuan-6115 wolf-yuan-6115 self-requested a review March 19, 2024 13:56
wolf-yuan-6115
wolf-yuan-6115 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@wolf-yuan-6115 wolf-yuan-6115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nat1anWasTaken
Nat1anWasTaken requested changes Mar 31, 2024
View reviewed changes
Copy link
Owner

@Nat1anWasTaken Nat1anWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM for the PR! I've issued some format changes.

main.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Qodana Community for Python

2 new problems were found

Inspection name Severity Problems
Unsatisfied package requirements 🔶 Warning 1
PEP 8 coding style violation ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.2
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Nat1anWasTaken
Nat1anWasTaken approved these changes Mar 31, 2024
View reviewed changes
Copy link
Owner

@Nat1anWasTaken Nat1anWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nat1anWasTaken Nat1anWasTaken merged commit 07cf2a6 into master Mar 31, 2024
3 checks passed
@Nat1anWasTaken Nat1anWasTaken deleted the 26-feat-custom-status-and-latency-display branch March 31, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf-yuan-6115 wolf-yuan-6115 wolf-yuan-6115 approved these changes

@Nat1anWasTaken Nat1anWasTaken Nat1anWasTaken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: custom status and latency display
3 participants
@Mantouisyummy @Nat1anWasTaken @wolf-yuan-6115