Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize static instance of EmissaryServer #1024

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jpdahlke
Copy link
Collaborator

  • removes the need for node.mode system property (get from command or default value)
  • no longer need to check namespace binding to determine state
  • deprecate stop/status methods for future cleanup

Pulled out of #900 but stops short of changing mode to enum and changing command validator.

@jpdahlke jpdahlke added framework This change will impact the core framework improvement A change that makes something easier to use labels Dec 16, 2024
@jpdahlke jpdahlke requested a review from dev-mlb December 16, 2024 22:27
Copy link
Collaborator

@dev-mlb dev-mlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, but otherwise looks good

@fbruton fbruton self-requested a review December 19, 2024 21:58
@jpdahlke jpdahlke added this to the v8.20.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework This change will impact the core framework improvement A change that makes something easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants