Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display bugs with column picker #743

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

alycejenni
Copy link
Member

@alycejenni alycejenni commented Jan 3, 2024

A list of already selected fields can now be passed to <FieldPicker> components (see #711). The column picker wasn't getting this list so it was throwing an error.

  • list of headers/fields now passed into column picker
  • default empty list used if no list passed in (this shouldn't happen, but at least it now won't break if it does)
  • position and min width set for column picker
  • css styles for field picker set for all field picker instances even if not under .term-editor

Fixes: #742

@alycejenni alycejenni merged commit 267c65c into dev Jan 3, 2024
2 checks passed
@alycejenni alycejenni deleted the ginger/column-picker branch January 3, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant