New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 Fix descriptions sometimes being inaccurate on RTL languages #48

Open

Log1x wants to merge 1 commit into Ne-Lexa:master from Log1x:fix/rtl-descriptions

Log1x commented May 24, 2023

This fixes inaccurate descriptions being thrown in some cases when scraping apps in RTL languages.

This was notably an issue with Tumblr. I am not deep enough into my scrape yet to notice any other discrepancies, so I'm hoping this is it.

// Requires the fix, otherwise it will return the English description.
$apps->getAppInfoForLocales('com.tumblr', ['ar']);

// Description is in the proper place.
$apps->getAppInfoForLocales('com.instagram.android', ['ar']);

Not sure what makes Tumblr unique in this scenario, but with a test of 1000 apps in 13 languages, this fix has proved to work as intended.


          🩹 Fix descriptions sometimes being inaccurate on RTL languages

7da668d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet