Block: Add test that double-spending blocks are rejected #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszepieniec
approved these changes
Nov 22, 2024
Sword-Smith
force-pushed
the
add-doublespend-test
branch
from
9e658cf to
42d0c20
Compare
Includes a rewrite of helper function for constructing a new block that makes it easier to create a new block from a BlockPrimitiveWitness. Specifically, a new function `block_template_from_primitive_witness` is added which is used in this test as well as in the call graph for creating a new block from a transaction and a predecessor. Also adds an "unsafe" version of MutatorSetUpdate's "apply" function that allows the caller to calculate a new MS accumulator which ignores double spends. This was needed to allow the BlockPrimitiveWitness constructor to complete the construction of a block with a double- spending transaction. TODO in future commit: Add a test that verifies that double spend *within* one block is also disallowed. Co-authored-by: Alan Szepieniec <alan@neptune.cash>
Sword-Smith
force-pushed
the
add-doublespend-test
branch
from
26d4469 to
95765ed
Compare
|
Merged in 4746a77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aszepieniec Let me know if these small rewrites conflict with your current work.
TODO (for future commits, not for this PR): Block's
is_validfunction should return an error code indicating why the block was rejected. That would make negative tests of block validity much more robust. I'll add an issue to that effect.Includes a rewrite of helper function for constructing a new block that makes it easier to create a new block from a BlockPrimitiveWitness. Specifically, a new function
block_template_from_primitive_witnessis added which is used in this test as well as in the call graph for creating a new block from a transaction and a predecessor.Also adds an "unsafe" version of MutatorSetUpdate's "apply" function that allows the caller to calculate a new MS accumulator which ignores double spends. This was needed to allow the BlockPrimitiveWitness constructor to complete the construction of a block with a double- spending transaction.