-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issues 3, 4 and 7 #9
base: master
Are you sure you want to change the base?
Conversation
@bugal thanks for the PR - just a couple quick notes I was going to mention:
Note that both of these changes are considered "rewriting history" on Github - therefore, a force push is required, which generally isn't kosher on PRs. However, if you'd like to do a force-push on your branch with these changes, I can get this assigned for review. |
Thanks for the reply, @aph3rson, I'm still getting used to github. |
I've taken a precursory look at the code, and it looks good. I'm asking the reporters of #4 to try the changes out on their side, as I don't have a clustered environment handy. |
Fixes some issues, so it works on clustered scenarios, and also adds some informational outputs when it can't find SQL Server instances or gets connection errors.
Tested on SQL Server 2008R2, SQL Server 2012 and SQL Server 2012 Cluster.