Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the pre-commit errors #75

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix the pre-commit errors #75

merged 1 commit into from
Oct 24, 2023

Conversation

abersnaze
Copy link
Contributor

I had to do a lot of work to get the local pre-commit run --all-files to pass.

@abersnaze abersnaze requested a review from jolynch October 19, 2023 18:17
@jolynch
Copy link
Contributor

jolynch commented Oct 19, 2023

Nice, can you add pre-commit run --all-files to

service-capacity-modeling/tox.ini

Line 15 in f0dde0d

mypy --ignore-missing-imports --check-untyped-defs --show-error-codes --follow-imports silent service_capacity_modeling tests
so we test it on every build and fail the build if folks don't properly lint?

@abersnaze abersnaze force-pushed the pre-commit branch 2 times, most recently from 0b7e7ff to e6a8174 Compare October 24, 2023 01:21
@abersnaze abersnaze merged commit 8b6bef1 into main Oct 24, 2023
6 checks passed
@abersnaze abersnaze deleted the pre-commit branch October 27, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolynch jolynch Awaiting requested review from jolynch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abersnaze @jolynch