-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRIS-722] Custom Tagging #2144
Open
RikishK
wants to merge
29
commits into
Netflix:master
Choose a base branch
from
zendesk:fsat/pr-1627--rebased--2.12.28
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+92
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikishK
force-pushed
the
fsat/pr-1627--rebased--2.12.28
branch
from
November 14, 2024 05:36
7a3be98
to
66e562e
Compare
RikishK
force-pushed
the
fsat/pr-1627--rebased--2.12.28
branch
from
November 18, 2024 04:28
edd8055
to
e178c81
Compare
RikishK
force-pushed
the
fsat/pr-1627--rebased--2.12.28
branch
from
November 19, 2024 01:52
dd7073a
to
00be0f0
Compare
RikishK
force-pushed
the
fsat/pr-1627--rebased--2.12.28
branch
3 times, most recently
from
November 21, 2024 05:13
2810093
to
0d45ad5
Compare
RikishK
force-pushed
the
fsat/pr-1627--rebased--2.12.28
branch
from
November 22, 2024 02:38
0d45ad5
to
4c5cebf
Compare
TestingSetup: Environment variable:
Step functions create command:
Flow:
Output/Result: Additional notes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options to add custom tags are in the order:
environment variable dictionary,
step functions cli create flag,
batch decorator variable dictionary
This PR builds ontop of this PR: #1628 - this original PR did not work when testing but I would like to credit it here as some of the changes are still used.