Use AtomicLongFieldUpdater in StepLong, StepDouble, and AtomicDouble #1158
Conversation
| @@ -124,4 +127,9 @@ public void max(double v) { | |||
| @Override public double doubleValue() { | |||
| return get(); | |||
| } | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
There was a problem hiding this comment.
Added a toString implementation to match the behavior of AtomicLong / AtomicInteger
kilink
force-pushed
the
atomic-field-updaters
branch
2 times, most recently
from
1ce7e11
to
e1fdb84
Compare
Use AtomicLongFieldUpdater to shrink the footprint of StepLong, StepDouble, and AtomicDouble.
kilink
force-pushed
the
atomic-field-updaters
branch
from
e1fdb84
to
645a878
Compare
|
Will need to do some testing on this, probably won't have time this week. |
Since the |
The common operations are now available directly on the StepLong/StepDouble.
Looks good to me. |
Use AtomicLongFieldUpdater to shrink the footprint of StepLong, StepDouble, and AtomicDouble.
From a heapdump for a typical app, we see tens of thousands of instances of these classes:
StepLong: 21,751 instances
StepDouble: 29,233 instances
AtomicDouble 31,822 instances
Getting rid of the object reference to an AtomicLong shrinks the allocation footprint and avoids the extra pointer chasing. Note that StepLong and StepDouble still have a field
currentthat is an AtomicLong / AtomicDouble; it can't be inlined into a volatile field without breaking backwards compatibility since it is exposed via thegetCurrentmethod.