Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test custom type serde #111

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

julienbrs
Copy link
Contributor

Issue: related to #70

Description

This PR adds unit tests for custom_type_serde. The primary focus of these tests is to demonstrate the use of custom types as inputs and outputs in contract calls, while intentionally not altering the contract's storage state.
Currently, person_input does not modify the storage, and person_output does not retrieve from it. If needed, I can enhance the smart contract (SC) to include state changes in a subsequent PR. Please let me know if such modifications are required.

@julio4
Copy link
Contributor

julio4 commented Nov 15, 2023

LGTM! Thank you!

@julio4 julio4 merged commit 25e9345 into NethermindEth:main Nov 15, 2023
1 check passed
@julienbrs julienbrs deleted the test-custom-type-serde branch November 15, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants