Randomness #183
Closed
Randomness #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio4
reviewed
May 17, 2024
src/ch01/dice_game_vrf.md
Outdated
Comment on lines
3
to
4
| This code provides an implementation of a Dice Game contract that utilizes a [Pragma Verifiable Random Function (VRF)](https://docs.pragma.build/Resources/Cairo%201/randomness/randomness) to generate random numbers on-chain. | ||
|
|
There was a problem hiding this comment.
What do you think about explaining a bit more about randomness in the context of blockchain before jumping directly in the implementation? Especially to outline where the entropy comes from and potential risks with it. You can then just link to Pragma - Randomness
There was a problem hiding this comment.
Entropy sources:
- Blockchain: block hashes, timestamps, ...
- External Sources: Oracles
Risks: Predictability/Manipulation/Centralization-trust
There was a problem hiding this comment.
Alright. I'll make an update to this week
|
@okhaimie-dev Hello! Let me know if you need any help on finishing this |
|
Done in #238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s): #128
Description
Added code for Dice Game VRF application.
Checklist
./scripts/cairo_programs_verifier.shsuccessfully