Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TTL to Operator RPC Client #259

Closed
wants to merge 34 commits into from
Closed

Add TTL to Operator RPC Client #259

wants to merge 34 commits into from

Commits on Jun 19, 2024

  1. Initial V2 impl for rpc_client

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    0b420fb View commit details
    Browse the repository at this point in the history

  2. Add retry later

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    27f918b View commit details
    Browse the repository at this point in the history

  3. Add submittedAt to actions

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    ae9904e View commit details
    Browse the repository at this point in the history

  4. Extract retry and retry later strategies

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    9e1e849 View commit details
    Browse the repository at this point in the history

  5. Add retryIfRecentEnough

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    890ac87 View commit details
    Browse the repository at this point in the history

  6. Add TestRetryLaterIfRecentEnough

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    9a46a4f View commit details
    Browse the repository at this point in the history

  7. Rename retry mechanism

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4fef16a View commit details
    Browse the repository at this point in the history

  8. Test retryAtMost

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    8e558f5 View commit details
    Browse the repository at this point in the history

  9. Store retryPredicate in struct member

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3950423 View commit details
    Browse the repository at this point in the history

  10. Separate impl from tests

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e0a82a0 View commit details
    Browse the repository at this point in the history

  11. Rename to AggregatorRpcClient

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    6a7c004 View commit details
    Browse the repository at this point in the history

  12. Don't use self

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    6b0107d View commit details
    Browse the repository at this point in the history

  13. Abstract rpc.Client

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3fc60c6 View commit details
    Browse the repository at this point in the history

  14. Add NewHTTPAggregatorRpcClient

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    658f752 View commit details
    Browse the repository at this point in the history

  15. Add AggregatorRpcClienter interface

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    17c134c View commit details
    Browse the repository at this point in the history

  16. Remove interface (single implementation)

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    ca0820a View commit details
    Browse the repository at this point in the history

  17. Rename client method names

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    b64cb17 View commit details
    Browse the repository at this point in the history

  18. Add TestGetAggregatedCheckpointMessages 

    Shows a clear data race
    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    5eae2a1 View commit details
    Browse the repository at this point in the history

  19. Make GetAggregatedCheckpointMessages blocking

    @emlautarom1
    emlautarom1 committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a0f833f View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Replace event loop with blocking code

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b5f5207 View commit details
    Browse the repository at this point in the history

  2. Add Metricable interface to AggregatorRpcClient

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    24b027e View commit details
    Browse the repository at this point in the history

  3. Use listener in SendSignedCheckpointTaskResponseToAggregator

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    cf09334 View commit details
    Browse the repository at this point in the history

  4. Use listener in SendSignedStateRootUpdateToAggregator

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5ec7d28 View commit details
    Browse the repository at this point in the history

  5. Use listener in SendSignedOperatorSetUpdateToAggregator

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e576b5f View commit details
    Browse the repository at this point in the history

  6. Add logs to GetAggregatedCheckpointMessages

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    22f5264 View commit details
    Browse the repository at this point in the history

  7. Add RetryWithDelay

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fefaa66 View commit details
    Browse the repository at this point in the history

  8. Rename parameter

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f3d197c View commit details
    Browse the repository at this point in the history

  9. Add RetryAnd to compose rather than decorators

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fc5665b View commit details
    Browse the repository at this point in the history

  10. Add DefaultRetryStrategy

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f71d642 View commit details
    Browse the repository at this point in the history

  11. Start aggregator before operator

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6a6db7d View commit details
    Browse the repository at this point in the history

  12. Replace original with v2

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    28b0005 View commit details
    Browse the repository at this point in the history

  13. Increase coverage by using different messages

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7bcc7ff View commit details
    Browse the repository at this point in the history

  14. Ensure retry strategy is local to each method call

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f4ee227 View commit details
    Browse the repository at this point in the history

  15. Typo

    @emlautarom1
    emlautarom1 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    9f3809e View commit details
    Browse the repository at this point in the history