Add aggregator and task generator setters #292
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, the rollup and main contracts don't allow the owner changing the aggregator and generator directly. This is acceptable, since the intended path was through an upgrade. However, it's more practical to add owner methods for that, and in a correct setup the trust assumptions would be similar, and without risking any possible issues that can happen in an upgrade.
New Behavior
This adds
setAggregatortoSFFLRegistryRollupandsetAggregatorandsetTaskGeneratortoSFFLTaskManageras owner methods. This allows transferring aggregator and generator privileges easily.This will also include the upgrade of deployed contracts, even though this is not breaking.
Breaking Changes
None.