Uprising and Downfall Remaster Feb 15 2024 #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talha-ahsan
requested review from
locks,
plural,
NoahTheDuke and
distributive
plural
requested changes
Feb 16, 2024
v2/cards/red_level_clearance.json
Outdated
| @@ -8,9 +8,9 @@ | |||
| "influence_cost": 2, | |||
| "is_unique": false, | |||
| "side_id": "corp", | |||
| "stripped_text": "Resolve two of the following in any order: * Draw 2 cards. * Gain 2 credits. * Install up to 1 non-agenda card. * Gain click.", | |||
| "stripped_text": "Resolve 2 of the following in any order: - Draw 2 cards. - Gain 2 credits. - Install 1 non-agenda card from HQ. - Gain click.", | |||
There was a problem hiding this comment.
should these be dashes or asterisks still?
| @@ -32,7 +32,7 @@ | |||
| { | |||
| "card_id": "stargate", | |||
| "card_set_id": "downfall", | |||
| "flavor": "\"Net <em>space</em> is an abstraction, a white lie protecting fragile comprehensions. Do not limit yourself.\" -z\\h/r", | |||
| "flavor": "“Net <em>space<em> is an abstraction, a white lie protecting fragile comprehensions. Do not limit yourself.”\n(ra)—z\\h/r(/ra}", | |||
There was a problem hiding this comment.
the (ra) should not be here.
plural
requested changes
Feb 16, 2024
| @@ -538,10 +538,10 @@ | |||
| "position": 92, | |||
| "quantity": 3, | |||
| "side_code": "runner", | |||
| "stripped_text": "click: Host 1 program or piece of hardware from your grip on this resource. 1 credit: Install 1 hosted card. The first card you install this way during each of your turns costs 1 credit less to install for each unique () connection you have installed.", | |||
| "stripped_text": "click: Host 1 program or piece of hardware from your grip faceup on this resource. 1 credit: Install 1 hosted card. The first card you install this way during each of your turns costs 1 credit less to install for each unique ({unique}) connection resource you have installed.", | |||
There was a problem hiding this comment.
{unique} should be stripped out in stripped_text.
plural
requested changes
Feb 16, 2024
| @@ -332,7 +328,7 @@ | |||
| { | |||
| "card_id": "cerebral_overwriter", | |||
| "card_set_id": "uprising", | |||
| "flavor": "You are being made sane.\n-u are bei-g mad- sa-e\nY-u ar- be-n-d-\n-u -r-?", | |||
| "flavor": "You are being made sane.<ul><li>u are bei-g mad- sa-e\nY-u ar- be-n-d-</li><li>u -r-?</li></ul>", | |||
There was a problem hiding this comment.
list formatting should not be here.
|
going to follow up quickly with fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.