Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unclosed em tags in flavor text. #844

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix unclosed em tags in flavor text. #844

merged 1 commit into from
Jul 3, 2024

Conversation

plural
Copy link
Collaborator

@plural plural commented Jul 1, 2024

Fixes #836 and the same issue for Stargate.

@plural plural requested a review from talha-ahsan July 1, 2024 03:58
@plural plural self-assigned this Jul 1, 2024
talha-ahsan
talha-ahsan approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@talha-ahsan talha-ahsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the import tool also need an update for the <em> rule for this?

@plural
Copy link
Collaborator Author

plural commented Jul 3, 2024

i'll add a test to the JSON repo for unclosed tags.

@plural plural merged commit 5bb7d5a into NetrunnerDB:main Jul 3, 2024
2 checks passed
@plural plural deleted the fix-em branch July 3, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talha-ahsan talha-ahsan talha-ahsan approved these changes

Assignees

@plural plural

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct Mantle Flavor Text Emphasis Tags
2 participants
@plural @talha-ahsan