-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: regenerate for 2.3.1 #189
Conversation
BREAKING CHANGE: `spikeThresh` is now a compulsory field
[skip ci]
Enable toggling of build time validation
These need to be set individually, and validation failing at each step will not work.
…idation-adding feat(memb-pots): do not validate on addition
Changes to generateDSI apologize if this is not the correct way to communicate. Just a heads-up. I have recently made changes (in generateDS These changes were necessary so that generateDS and the code it
See https://docs.python.org/3/whatsnew/3.12.html I suspect that in order to support Python 3.12, you will need these Dave Kuhlman |
Hi @dkuhlman : thanks for that. We've run into those issues before and we fix them as we go. I think the code will still work, it'll just throw a syntax warning. Our linters/tests should hopefully catch any errors---we've not had anything break because of this yet (for example in https://github.com/NeuroML/pyNeuroML, which uses libNeuroML extensively). Thanks again for generateDS :) |
BREAKING CHANGE:
spikeThresh
is now a compulsory field