Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: regenerate for 2.3.1 #189

Merged
merged 13 commits into from
Jun 11, 2024
Merged

feat!: regenerate for 2.3.1 #189

merged 13 commits into from
Jun 11, 2024

Conversation

sanjayankur31
Copy link
Contributor

BREAKING CHANGE: spikeThresh is now a compulsory field

@pgleeson pgleeson merged commit 3ee1528 into development Jun 11, 2024
37 checks passed
@dkuhlman
Copy link

dkuhlman commented Jun 11, 2024

Changes to generateDS

I apologize if this is not the correct way to communicate.
Please give me a pointer is so.

Just a heads-up. I have recently made changes (in generateDS
v. 2.44.1) to the use and generation of regular expressions in
generateDS.

These changes were necessary so that generateDS and the code it
generates can run under Python 3.12. The following is from "What’s
New In Python 3.12":

"A backslash-character pair that is not a valid escape sequence
now generates a SyntaxWarning, instead of DeprecationWarning.
For example, re.compile("\d+\.\d+") now emits a SyntaxWarning
("\d" is an invalid escape sequence, use raw strings for regular
expression: re.compile(r"\d+\.\d+")). In a future Python
version, SyntaxError will eventually be raised, instead of
SyntaxWarning. (Contributed by Victor Stinner in gh-98401.)"

See https://docs.python.org/3/whatsnew/3.12.html

I suspect that in order to support Python 3.12, you will need these
changes.

Dave Kuhlman

@sanjayankur31
Copy link
Contributor Author

Hi @dkuhlman : thanks for that. We've run into those issues before and we fix them as we go. I think the code will still work, it'll just throw a syntax warning. Our linters/tests should hopefully catch any errors---we've not had anything break because of this yet (for example in https://github.com/NeuroML/pyNeuroML, which uses libNeuroML extensively).

Thanks again for generateDS :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants