Changes needed to get EEG-ExPy building and running on Apple Silicon chips #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellet
changed the title
This commit introduces multiple changes that ensure compatibility with macOS Apple Silicon. The 'keyboard' dependency was removed because of segmentation faults, and it was replaced with 'pynput'. The versions of 'pylsl', 'pyobjc', and 'psychopy' were specified to prevent dependency resolution loop and solve issues on Apple Silicon. The 'conda' installation step was added to the GitHub Actions workflow to facilitate installation of these dependencies. Some experiment and analytical scripts were also updated accordingly for compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest changes needed were using conda to install some dependencies on the MacOS-latest github runner. Conda is already part of the normal installation process so might be ok?
Unfortunately had to remove the keyboard module entirely since it is currently throwing a segmentation fault on Apple Silicon macOS, luckily it seems to have been only used in one place and I replaced it with the pynput module, still have not tested the replaced code yet though.