Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace and Update Datetime Parser #525

Merged
merged 14 commits into from
Jul 27, 2023
Merged

Conversation

lawrence-mbf
Copy link
Collaborator

Fixes #512

Motivation

To replace and update the datetime parser so it can be generalized following #512

How to test the behavior?

Reading and writing NWB files should be sufficient as they all need to update their file_create_date properties.

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@lawrence-mbf lawrence-mbf self-assigned this Jul 26, 2023
datetimes cannot be concatenated if their time zone values are different
for some reason.
- Slightly shorten some test data.
- Fix datetime comparison precision.
Includes MATLAB default common times and moves formatting into
correctType instead.
New MATLAB versions might return an array of strings from h5load().
This was not handled correctly beforehand and accidentally created char
matrices. These now convert string arrays properly to cell arrays of
character vectors.
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #525 (db1a6d3) into master (601ee60) will decrease coverage by 0.24%.
The diff coverage is 84.86%.

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   87.84%   87.61%   -0.24%     
==========================================
  Files         129      130       +1     
  Lines        5489     5537      +48     
==========================================
+ Hits         4822     4851      +29     
- Misses        667      686      +19     
Files Changed Coverage Δ
+io/timestamp2datetime.m 68.96% <68.96%> (ø)
+types/+util/correctType.m 92.94% <92.94%> (+2.46%) ⬆️
+io/mapData2H5.m 97.77% <100.00%> (+0.15%) ⬆️
+tests/+unit/dataStubTest.m 98.43% <100.00%> (-0.07%) ⬇️
+tests/+util/verifyContainerEqual.m 100.00% <100.00%> (ø)
+types/+untyped/DataStub.m 95.59% <100.00%> (+0.44%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lawrence-mbf lawrence-mbf marked this pull request as ready for review July 27, 2023 18:38
@lawrence-mbf lawrence-mbf merged commit b7583a3 into master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support Truncated Time Zones and Times for isodatetime
1 participant