-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace and Update Datetime Parser #525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datetimes cannot be concatenated if their time zone values are different for some reason.
- Slightly shorten some test data. - Fix datetime comparison precision.
Includes MATLAB default common times and moves formatting into correctType instead.
New MATLAB versions might return an array of strings from h5load(). This was not handled correctly beforehand and accidentally created char matrices. These now convert string arrays properly to cell arrays of character vectors.
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
- Coverage 87.84% 87.61% -0.24%
==========================================
Files 129 130 +1
Lines 5489 5537 +48
==========================================
+ Hits 4822 4851 +29
- Misses 667 686 +19
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512
Motivation
To replace and update the datetime parser so it can be generalized following #512
How to test the behavior?
Reading and writing NWB files should be sufficient as they all need to update their
file_create_date
properties.Checklist
fix #XX
whereXX
is the issue number?