Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link validation function (issue #559) #634

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Nov 21, 2024

Fix #559

Motivation

Fix issue

How to test the behavior?

See issue for examples

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad
Copy link
Collaborator Author

ehennestad commented Nov 21, 2024

Todo:

@ehennestad ehennestad changed the title Update link validation function #559 Update link validation function (issue #559) Nov 23, 2024
@ehennestad ehennestad marked this pull request as ready for review November 28, 2024 10:02
@bendichter
Copy link
Contributor

To do:

  • update tutorials to not use explicit softlinks
  • add warning for using string in SoftLink

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (42e9995) to head (840889f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   95.17%   95.15%   -0.03%     
==========================================
  Files         113      113              
  Lines        4750     4768      +18     
==========================================
+ Hits         4521     4537      +16     
- Misses        229      231       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehennestad ehennestad merged commit 6fb3b3a into master Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Softlinks does not enforce the correct type, nor is it required to add a linked type as a softlink
2 participants