-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to use sphinx #643
Conversation
…ting Add "sections" Specify input and output arguments Reformat examples
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #643 +/- ##
==========================================
+ Coverage 95.15% 95.23% +0.08%
==========================================
Files 113 115 +2
Lines 4768 4873 +105
==========================================
+ Hits 4537 4641 +104
- Misses 231 232 +1 ☔ View full report in Codecov by Sentry. |
(files are now located in docs/source/_static/html/tutorials)
Fix: Make sure neurodata types specfied with "short names" in the documentation for properties of generated classes are properly linked to their corresponding class pages in the docs i.e (TimeSeries) Add links to the nwb format specification for each type
- Add docstring processors for adding role to class properties and change formatting for sphinx-autodetected class constructor from reference to constructor method to reference for class
This looks really great! The tutorials and API docs both look really nice. I love the cross-links in the API docs to the schema and schema docs for each of the classes. I think the main remaining point here would be to modify the README.md. We should:
I have a few very minor suggestions that should not be blocking:
Next steps:
|
Should have done this already. Maybe refresh browser? Let me know if you find links pointing to the old docs |
Would it be possible to include links to the youtube video walkthroughs of the tutorials within the page? |
It might be nice to keep these links as convenience for people exploring the livescripts in MATLAB. It seems MATLAB's html-export automatically changes the extension of links from .mlx to .html so this should work without interventions as long as the relative locations are kept consistent (I did not test it yet, but will try) |
Looks awesome! Let's merge as soon as the tests pass |
…eurodataWithoutBorders/matnwb into update-documentation-to-sphinx
@ehennestad do you want to remove the draft status? |
I want to add a section about the dimensions and how text in the documentation about time series dimensions are inconsistent with how matnwb works |
add section from matnwb readme add pages from nwb-overview minor rearrangement
Motivation
Previous documentation relied on outdated scripts. This PR adds tools for autogenerating documentation using sphinx-matlabdomain.
New documentation page: https://matnwb.readthedocs.io/en/latest/index.html
Todo
Checklist
fix #XX
whereXX
is the issue number?