Download GIN Data for Pipeline Tests #795
Conversation
|
The design of this has several issues (I know they are still present on NeuroConv side, that suite is a bit touchier to refactor) and this is an opportunity to at least start off on the right foot here I highlighted the newer approach in this issue: hdmf-dev/hdmf#1113 I can handle this over the weekend unless you really want to take a crack at it |
…odatawithoutborders/nwb-guide into download-gin-data-for-tests
|
@garrettmflynn OK I got this to a more streamlined point in terms of deployment, display, etc. However, the pipeline tests are still skipping everything; perhaps a data path needs to be configured in some way? https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/9258765691/job/25469483408?pr=795#step:17:209 Would it be possible to adjust those tests to fail instead of skip when files are missing (ideally with an informative error message of 'data not found' per test)? Feel free to take over this PR again to try to get the CI working as expected |
|
Yeah the data needs to go to a very specific location in the filesystem. I've made it so that the test should fail if it isn't there (instead of skipping). |
…odataWithoutBorders/nwb-guide into download-gin-data-for-tests
for more information, see https://pre-commit.ci
…odataWithoutBorders/nwb-guide into download-gin-data-for-tests
for more information, see https://pre-commit.ci
| - name: Set working directory as environment variable | ||
| run: echo "CURRENT_WORKING_DIR=$(pwd)" >> $GITHUB_ENV | ||
| if: runner.os != 'Windows' | ||
|
|
||
| - name: Set working directory as environment variable (Windows) | ||
| run: echo "CURRENT_WORKING_DIR=%cd%" >> $env:GITHUB_ENV | ||
| shell: cmd | ||
| if: runner.os == 'Windows' |
There was a problem hiding this comment.
For this style, I would recommend this syntax at the top of the file
env:
CURRENT_WORKING_DIR: ${{ github.workspace }}There was a problem hiding this comment.
Oh sure. I'm hoping to remove this ASAP.
It shows that we can, in fact, save a .env file and display the value on Windows. The Set working directory as environment variable option was simply to see if we can access something like this cross-platform. Will try this global env variable out!
Just switched the test pipeline workflow to use the exact same configuration for saving the .env file. Should tell us whether we're configuring GitHub Actions wrong or the test pipeline action is somehow not compatible with saving an .env file.
There was a problem hiding this comment.
It shows that we can, in fact, save a .env file and display the value on Windows. The Set working directory as environment variable option was simply to see if we can access something like this cross-platform. Will try this global env variable out!
I saw that... CI can be really confusing sometimes
One thing it might be is the conda activation step, which swaps to a different shell type (and maybe the .env thing is only available from the default bash??)
There was a problem hiding this comment.
Yep looks like it. Now that we're digging into this, it looks like the Live service tests are also not behaving as expected—possibly as a consequence of these inconsistencies.
In both Dev and Live tests, No DANDI API key provided is printed to the console—despite the latter doing a similar dump to an environment file.
There was a problem hiding this comment.
Hmm although is this only happening in this PR?
There was a problem hiding this comment.
Nevermind, this was just a consequence of not registering the DANDI API Key secret
|
OK just gonna get this in, continue work on Windows over on #816 |
This PR fixes the issue noted in #792 where the pipeline tests don't actually test anything because there is no test data found.
@CodyCBakerPhD Would you mind adding all the appropriate secrets for this workflow to run?