Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise best practice violation if ":" in container name #532

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 10, 2024

Motivation

Related to hdmf-dev/hdmf-zarr#219 and hdmf-dev/hdmf#1202

@bendichter bendichter self-requested a review November 27, 2024 22:35
Co-authored-by: Ben Dichter <ben.dichter@gmail.com>
@rly
Copy link
Contributor Author

rly commented Nov 28, 2024

Tests will fail until the new HDMF release which allows a user to create an object with "/" or ":" in the name in construct mode only.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.81%. Comparing base (165c727) to head (12d9561).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/nwbinspector/checks/_general.py 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #532       +/-   ##
===========================================
- Coverage   82.71%   58.81%   -23.91%     
===========================================
  Files          47       47               
  Lines        1510     1515        +5     
===========================================
- Hits         1249      891      -358     
- Misses        261      624      +363     
Files with missing lines Coverage Δ
src/nwbinspector/checks/__init__.py 100.00% <ø> (ø)
src/nwbinspector/checks/_general.py 84.00% <80.00%> (-16.00%) ⬇️

... and 22 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants