MCS-1990 Trying to get the webenabled downloads to work #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-1
to
4
| from enum import Enum, unique | ||
| from enum import Enum | ||
|
|
||
|
|
||
| @unique | ||
| class TaskDescription(Enum): |
There was a problem hiding this comment.
For some reason this particular decorator was causing pyinstaller to fail...
| @@ -60,6 +60,7 @@ def get_version(): | |||
| 'numpyencoder==0.3.0', | |||
| 'opencv-python==4.4.0.46; python_version<="3.9"', | |||
| 'opencv-python==4.5.4.60; python_version>="3.10"', | |||
| 'portalocker', | |||
There was a problem hiding this comment.
If this branch never gets merged, it'd probably be good to add this to the setup.py on the development branch
ThomasSchellenbergNextCentury
requested review from
rartiss55,
phile-caci and
NDCACI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, we should be able to double-click on the "mcsweb" package file (binary/executable) to start the application.
NOTES BEFORE YOU BEGIN:
pip install portalockerbefore you use pyinstaller (I've just added it to the MCSsetup.pyfile, but since it wasn't there for the latest release, you'll need to do it manually for now).127.0.0.1:8080/mcsinstead oflocalhost:8080/mcsSTATUS REPORT:
Previously we tested by executing
./dist/mcsweb/mcswebon the command line (from thewebenabled/folder), and this still works on Linux.As an intermediary step, I tried executing
./mcsweb(from thewebenabled/dist/mcsweb/folder). There were a few problems that I've since resolved, so that also works on Linux. As you'll see in the "Package" instructions on the README, the resolution involved copying a bunch of files into thedist/mcsweb/folder (not ideal, but, hey, it works).PROBLEM 1: Unfortunately, double-clicking on the binary in Linux doesn't work; you can still load the webpage, but Unity doesn't start, so clicking on a scene doesn't do anything. Since running things this way means you can't see log messages in a terminal, I don't know what sort of error is being thrown. You could try temporarily hard-coding the logger in
mcsweb.pyto write to a log file, which might get you some information.PROBLEM 2: I can't get the Windows package to run at all, for any of these three methods; the flask server starts, but when I open the webpage, I get a ModuleNotFoundError for the watchdog python module, which should be installed correctly on my machine... I don't remember who originally tested this on Windows (maybe it was Phi?), but I'm not sure why it's not working at all anymore.