Skip to content

Commit

Permalink
Merge pull request ocaml#13431 from NathanReb/notify-ppx-maintainers
Browse files Browse the repository at this point in the history
Simplify Parsetree change action and add ppxlib maintainers mention
  • Loading branch information
Octachron authored Nov 27, 2024
2 parents 703ba8e + 19b116d commit 40c56ff
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 68 deletions.
14 changes: 0 additions & 14 deletions .github/workflows/hygiene.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,20 +47,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
if: github.event_name == 'pull_request'

- name: Parsetree updated
run: >-
tools/ci/actions/check-parsetree-modified.sh
'${{ github.event.pull_request.issue_url }}'
'${{ github.ref }}'
'pull_request'
'${{ github.event.pull_request.base.ref }}'
'${{ github.event.pull_request.base.sha }}'
'${{ github.event.pull_request.head.ref }}'
'${{ github.event.pull_request.head.sha }}'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
if: github.event_name == 'pull_request'

- name: configure correctly generated
run: >-
tools/ci/actions/check-configure.sh
Expand Down
39 changes: 39 additions & 0 deletions .github/workflows/parsetree-change.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Parsetree Updated

on:
pull_request:
paths:
- 'parsing/parsetree.mli'
- 'parsing/asttypes.mli'
- 'parsing/location.mli'
- 'parsing/longident.mli'
- 'parsing/parse.mli'
- 'parsing/pprintast.mli'

jobs:
comment-and-label:
if: ${{! contains(github.event.pull_request.labels.*.name, 'parsetree-change')}}
permissions:
pull-requests: write
runs-on: ubuntu-latest
steps:
- name: Notify ppxlib maintainers
uses: actions/github-script@v7
with:
script: |
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: 'CC @ocaml/ppxlib-dev'
})
- name: Label PR
uses: actions/github-script@v7
with:
script: |
github.rest.issues.addLabels({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
labels: ['parsetree-change']
})
5 changes: 5 additions & 0 deletions Changes
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,11 @@ Working version

### Build system:

- #13431: Simplify github action responsible for flagging PRs with
the `parsetree-changes` label and extend it to mention the @ppxlib-dev
team.
(Nathan Rebours, review by Florian Angeletti)

### Bug fixes:

- #13408: Fix misplaced debug runtime assertion triggerable by a race
Expand Down
54 changes: 0 additions & 54 deletions tools/ci/actions/check-parsetree-modified.sh

This file was deleted.

0 comments on commit 40c56ff

Please sign in to comment.