-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added overload of AddKeycloakWebAppAuthentication #146
base: main
Are you sure you want to change the base?
Conversation
…ausing breaking changes. The sub claim is not mapped into the user's claims list without disabling claimMapping. Exposing the ConfigureOpenIdConnectionOptions allows this to be worked around
string configSectionName = KeycloakAuthenticationOptions.Section, | ||
string openIdConnectScheme = OpenIdConnectDefaults.AuthenticationScheme, | ||
string cookieScheme = CookieAuthenticationDefaults.AuthenticationScheme, | ||
Action<OpenIdConnectOptions>? configureOpenIdConnectOptions=null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix formatting
...ak.AuthServices.Authentication/WebAppExtensions/KeycloakWebAppServiceCollectionExtensions.cs
Show resolved
Hide resolved
Maybe we should include this workaround into core of this library instead of adding workaround? |
Link to changes: https://learn.microsoft.com/en-us/dotnet/core/compatibility/aspnet-core/8.0/securitytoken-events However, this was what i used to get the original claims from keycloak with the new overload:
|
Please do not delete |
@awchristie1 could you please rebase to main and not remove |
Added overload of AddKeycloakWebAppAuthentication due to dotnet 8.0 causing breaking changes. The sub claim is not mapped into the user's claims list without disabling claimMapping. Exposing the ConfigureOpenIdConnectionOptions allows this to be worked around.