Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all the issues in the codes #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

himank004
Copy link

Your checklist for this pull request

  • I have committed only those files that are required.
  • I have tried commit messages concise and reflective of the code committed.
  • I have used a branch name reflective of the issue.
  • If there is relavant issue for the PR, I have used closes #<issue number> to auto-close the issue once PR is merged.

Detailed description
1.First i took up the addition.py file and then corrected it by replacing the " * " by " + "
and this is the mistake in the addition.py this is a typo error or misplace by fst typing.

2.The GCD is using the same formula as the addition , so i replaced it with the gcd formula which uses a function called gcd .

3.The simple_interest the maximum of the formula is correct but they forget to divide the total product with 100 'and i added the update that is divided by 100 , so this produces the correct output.

Test plan (required)
first tesing the values givrn by the contributor
whch are given they are claiming that it shows an error so i tested the edited code on the same constraints and confirmed that whether the expected output is generated or not.
README.md

Closing issues

closes #1
closes #2
closes #3

performing addition instead of gcd
the total product divided by 100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple Interest Calculator gives wrong output Greatest Common Divisor Not working Addition not working
1 participant