Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing_Issues #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Hussain-Sharif
Copy link

Your checklist for this pull request

  • I have committed only those files that are required.
  • I have tried commit messages concise and reflective of the code committed.
  • I have used a branch name reflective of the issue.
  • If there is relavant issue for the PR, I have used closes #<issue number> to auto-close the issue once PR is merged.

Detailed description
#1 It is type error found in the code is now fixed!--->type error--->>['*'-->'+']
#2 Logic of GCD is incorrect --->I fixed by implementing a Logic without using PYTHON modules
#3 In 7th line it is calculating error missed '/100' to it

Test plan (required)
#1
add
#2
gcd
#3
interest

Closing issues

closes #1 ,#2 & #3

type error--->>['*'-->'+']
num1 > num2 or vice versa
Just divided the interest logic with 100 because we taking the rate in percentage {%}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition not working
1 participant