Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install .nix-channels and nix.conf with 644 instead of 664 #12031

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Dec 9, 2024

Motivation

As far as I can tell, there's no real reason either of these need to be 664. I'm willing to bet they were just a typo that has lasted for 7 years. While this shouldn't change anything, this is, IMHO, more correct, so let's stop perpetuating the wrong mode!

NB: We just made this same change in our nix-installer: DeterminateSystems/nix-installer#1316

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

As far as I can tell, there's no real reason either of these need to
be 664. I'm willing to bet they were just a typo that has lasted for
7 years. While this shouldn't change anything, this is, IMHO, more
correct, so let's stop perpetuating the wrong mode!
@cole-h cole-h requested a review from edolstra as a code owner December 9, 2024 19:20
@Mic92
Copy link
Member

Mic92 commented Dec 9, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Dec 9, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Dec 9, 2024
Copy link
Contributor

mergify bot commented Dec 9, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@Mic92
Copy link
Member

Mic92 commented Dec 10, 2024

@mergify rebase

Copy link
Contributor

mergify bot commented Dec 10, 2024

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@DeterminateSystems needs to authorize modification on its head branch.

@Mic92 Mic92 merged commit 8c25eac into NixOS:master Dec 10, 2024
11 of 12 checks passed
@cole-h cole-h deleted the fixup-mode-typos branch December 10, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants