Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format/init #1489

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Format/init #1489

merged 3 commits into from
Jul 2, 2024

Conversation

hsjobeki
Copy link
Contributor

Adds formatting checks to the CI

with using "prettier" with "prettier-plugin-astro"

Locally developers can run:

nix run .#format to format the src directory`

Alternatively / Additionally:

Use any LSP that has prettier support.

or run:

npm run format
npm run format:check

Ci executes:

nix build .\#checks.x86_64-linux.format

Which fails if the formatting is not in the required format which will ensure the format stays consistent.

@hsjobeki hsjobeki force-pushed the format/init branch 2 times, most recently from d42041f to 9a5edc6 Compare June 28, 2024 13:26
@hsjobeki
Copy link
Contributor Author

hsjobeki commented Jun 28, 2024

Maybe we should use treefmt and override the prettier package there...
(Could be another PR ? )
If done right the astro formatting would not change

@tomberek
Copy link
Contributor

I've not looked at the workflow yet, but likely would want a .git-blame-ignore-revs

@hsjobeki
Copy link
Contributor Author

hsjobeki commented Jul 1, 2024

I've not looked at the workflow yet, but likely would want a .git-blame-ignore-revs

  • Added .git-blame-ignore-revs

Copy link
Collaborator

@thilobillerbeck thilobillerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 could you update your branch to the current state of main? Then I'll merge it. :)

Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Let's just do a conflict resolution.

@hsjobeki hsjobeki force-pushed the format/init branch 3 times, most recently from fa07582 to 3fc3795 Compare July 2, 2024 19:34
@thilobillerbeck thilobillerbeck merged commit e43b7f4 into NixOS:main Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants