Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some types of InlineSVG #1497

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

hsjobeki
Copy link
Contributor

@hsjobeki hsjobeki commented Jul 2, 2024

  • extend the Intrinsic svg html attributes

instead of explicit type cast, which is more unsafe

  • Add as const

Which creates more narrow type unions for e.g the color "lightblue" | "orange" | "green" instead of "string" for the non-const expression

@thilobillerbeck thilobillerbeck merged commit e67b1b3 into NixOS:main Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants