Merge pull request #324495 from JohnRTitor/fix-gnome-clocks

gnome-clocks: add missing gstreamer dependency

pkgs/desktops/gnome/apps/gnome-clocks/default.nix

@@ -1,34 +1,35 @@
-{ stdenv
-, lib
-, fetchurl
-, meson
-, ninja
-, gettext
-, pkg-config
-, wrapGAppsHook4
-, itstool
-, desktop-file-utils
-, vala
-, libxml2
-, gtk4
-, glib
-, sound-theme-freedesktop
-, gsettings-desktop-schemas
-, gnome-desktop
-, geocode-glib_2
-, gnome
-, gdk-pixbuf
-, geoclue2
-, libgweather
-, libadwaita
+{
+ stdenv,
+ lib,
+ fetchurl,
+ meson,
+ ninja,
+ gettext,
+ pkg-config,
+ wrapGAppsHook4,
+ itstool,
+ desktop-file-utils,
+ vala,
+ libxml2,
+ gtk4,
+ glib,
+ gsettings-desktop-schemas,
+ gnome-desktop,
+ geocode-glib_2,
+ gnome,
+ gdk-pixbuf,
+ geoclue2,
+ gst_all_1,
+ libgweather,
+ libadwaita,
 }:
 
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
  pname = "gnome-clocks";
  version = "46.0";
 
  src = fetchurl {
- url = "mirror://gnome/sources/gnome-clocks/${lib.versions.major version}/${pname}-${version}.tar.xz";
+ url = "mirror://gnome/sources/gnome-clocks/${lib.versions.major finalAttrs.version}/gnome-clocks-${finalAttrs.version}.tar.xz";
  hash = "sha256-6qPFeM3O+XVOZotWJnCbc/NSZxAjX0tyB20v9JpPmcc=";
  };
 
@@ -44,24 +45,24 @@ stdenv.mkDerivation rec {
  libxml2
  ];
 
- buildInputs = [
- gtk4
- glib
- gsettings-desktop-schemas
- gdk-pixbuf
- gnome-desktop
- geocode-glib_2
- geoclue2
- libgweather
- libadwaita
- ];
-
- preFixup = ''
- gappsWrapperArgs+=(
- # Fallback sound theme
- --prefix XDG_DATA_DIRS : "${sound-theme-freedesktop}/share"
- )
- '';
+ buildInputs =
+ [
+  gtk4
+  glib
+  gsettings-desktop-schemas
+  gdk-pixbuf
+  gnome-desktop
+  geocode-glib_2
+  geoclue2
+  libgweather
+  libadwaita
+ ]
+  ++ (with gst_all_1; [
+  # GStreamer plugins needed for Alarms
+ gstreamer
+ gst-plugins-base
+  gst-plugins-good
+  ]);
 
  doCheck = true;
 
@@ -72,12 +73,21 @@ stdenv.mkDerivation rec {
  };
  };
 
- meta = with lib; {
+ meta = {
  homepage = "https://apps.gnome.org/Clocks/";
- description = "Clock application designed for GNOME 3";
+ description = "A simple and elegant clock application for GNOME";
+ longDescription = ''
+ A simple and elegant clock application. It includes world clocks, alarms,
+ a stopwatch, and timers.
+
+ - Show the time in different cities around the world
+ - Set alarms to wake you up
+ - Measure elapsed time with an accurate stopwatch
+ - Set timers to properly cook your food
+ '';
  mainProgram = "gnome-clocks";
- maintainers = teams.gnome.members;
- license = licenses.gpl2Plus;
- platforms = platforms.unix;
+ maintainers = lib.teams.gnome.members;
+ license = lib.licenses.gpl2Plus;
+ platforms = lib.platforms.unix;
  };
-}
+})