-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
programs.fzf.enable breaks some bash completions #303195
Comments
Thanks for the report, I started a PR super-seeded by #303201 fixing this issue. As what I found this issue was already there previously but as most people didn't had the full integration enabled it didn't triggered the issue. |
Is there any progress on this? Solution PRs seem to have been closed? |
The fix already got merged and will be soon on unstable - otherwise you might cherry-pick/overlay it. |
Cool, so we can close this presumably? |
I looked at this in master and now we're basically back to how the fzf module was previously, right? So then it should still be an issue when enabling
|
Alright, so now I'm just gonna try my luck with a PR. It definitely works for me and makes a difference. |
put all of fzf initialization after the bash-completions initialization in bashrc, as the upstream project suggests in junegunn/fzf#72 Fixes: NixOS#303195
Describe the bug
The last fzf update in nixos-unstable breaks certain bash-completions, for example git.
Steps To Reproduce
This happens since e3812e1
Then try bash completion for git.
My
/etc/bashrc
looks like thisExpected behavior
The regular bash completions for git should work.
As a fix I found this old issue in fzf junegunn/fzf#72
To test this, I tried simply replacing
/etc/bashrc
with an edited version thatputs the fzf eval after the bash completions code (and before the alias
declarations). This fixes the issue. However, I am not sure how to solve this
cleanly in NixOS.
The bash completion code is inserted using
programs.bash.promptPluginInit
butI don't know how to enforce ordering so that the fzf eval happens after the
completions.
Notify maintainers
@SebTM
Metadata
Please run
nix-shell -p nix-info --run "nix-info -m"
and paste the result.Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: