-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/fzf: add package option, fix ordering, and other cleanup #303201
Conversation
… and before aliases
Thanks for the contribution - as yours super-seeds mine can you please add the mkAfter for all interactiveShellInit as it would override otherwise? |
If possible otherwise I can do a follow-up otherwise: could you please add #303145 and what I proposed here? #298692 (comment) |
nixos/modules/programs/fzf.nix
Outdated
inherit (lib) maintainers; | ||
inherit (lib.meta) getExe; | ||
inherit (lib.modules) mkIf mkRemovedOptionModule; | ||
inherit (lib.options) mkEnableOption; | ||
inherit (lib.strings) optionalString; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take the functions from lib. Where they are exactly is an implementation detail and just complicates things here.
Also we would avoid maintaining this list of functions by just prefixing the functions with lib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where they are exactly is an implementation detail
Being explicit is always better. And as we know there are many functions not even exposed at the top level or have the same name in multiple scopes.
I don't know how fish works, do you have some example for this?
Not sure what is being asked, actually. |
Never-mind, didn't saw the change to the bash-option and it already orders correct for zsh and might for fish not fully sure on that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the formatting discussion if there are guidelines for/against this particular case - but overall LGTM.
Description of changes
with lib;
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.