-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FZF missing /share/fzf. #303381
Comments
Do you have the |
Can you try adding to |
I don't appear to, no. I hadn't needed it before. I'll install it and report back. |
Wouldn't this just create /share/fzf on /? I'm not sure what this will help. |
This had no effect. |
I tried putting fzf_setup_using_base_dir:source:56: no such file or directory: /usr/share/fzf/key-bindings.zsh
[oh-my-zsh] fzf plugin: Cannot find fzf installation directory.
Please add `export FZF_BASE=/path/to/fzf/install/dir` to your .zshrc I am pretty sure the issue is that the output for fzf-0.49.0 doesn't have share/fzf in it, which is what the fzf plugin is looking for. These are the contents of the share directory in the output: ┌─( ❄️ yaro@loki at 11:32:07 )─[ 10.10.255.124 ]──────────────( ~
├─{ zsh took 25ms
└─< 😸 > ls /nix/store/psmylmimp0023yibdx1w76hf8zds0sjj-fzf-0.49.0/share
nvim vim-plugins By contrast, here is what I find in a previous version: ┌─( ❄️ yaro@loki at 11:32:56 )─[ 10.10.255.124 ]──────────────( ~
├─{ zsh took 144ms
└─< 😸 > ls /nix/store/sif8a7y7p7r7wxpww2inxfrckni69c1a-fzf-0.47.0/share
fish fzf nvim vim-plugins It's missing "fzf" which I think would be fairly important, no? |
fwiw |
Tried making that and it still didn't change anything. |
Ah I think it was removed in #298692, but will be brought back in #303213. But I may be missing some context since I didn't really follow the discussion on updating 0.49.0. cc @SebTM @SuperSandro2000 |
Thank you. I'll wait for the PR to land in nixpkgs-unstable and let you know. |
Hey, I've merged the fix PR in question - you can use https://nixpk.gs/pr-tracker.html?pr=303213 to check the status - please do not forget to close the issue if it is resolved ultimately 🙏🏻 |
Describe the bug
The fzf-0.49.0 package is missing /share/fzf, which is causing the following to appear on my terminal whenever I start my shell:
Googling tells me FZF_BASE is supposed to indicate /usr/share/fzf, or in the case of nixpkgs/NixOS: ${pkgs.fzf}/share/fzf.
When I look at previous versions of the package, I see the directory is there, but not in fzf-0.49.0.
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
No message displayed and proper fzf integration where needed, and fzf's share directory being present.
Notify maintainers
@Br1ght0ne
@Ma27
@zowoq
Metadata
Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: