-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tlpui: init at 1.5.0 #188278
base: master
Are you sure you want to change the base?
tlpui: init at 1.5.0 #188278
Conversation
2d35973
to
55cf28e
Compare
Is there any unfinished work? |
Yes, unfortunately this was merely a quick draft to test the build of tlpui. Also see d4nj1/TLPUI#86 and d4nj1/TLPUI#112. |
Maybe write a simple patch on it and wait for the pr to be merged? |
The issue is that TLP-UI needs an intrinsic default file on runtime and therefore it won't run properly when just deactivated as suggested in https://github.com/d4nj1/TLPUI/pull/112/files |
Also, make some test work and make minor package refactors
so the package know uses the intrinisic defaults provided by the tlp package. Also, there is still an issue with using |
is this still being worked on? i might pick it up over the weekend, but i also understand the inherent flaws of using tlpui, as definitions in nix config will override it. A potential solution would be to have tlpui generate the tlp.conf in /etc/tlp.conf and move the nix module for tlp to use |
I gave this PR an update as well as looked into fixing the inherent flaws of the existing nixos module overriding what tlpui generates, that approach can be found in #305278. Happy to take criticism over there too, i understand i made some changes that need to be considered carefully |
Description of changes
Added tlpui as a nix package.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes