-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xbar: init at 2.1.7-beta #209794
base: master
Are you sure you want to change the base?
xbar: init at 2.1.7-beta #209794
Conversation
b11b104
to
092aef2
Compare
@Janik-Haag I read from maintainer-list.nix about invitation to the orgs. How to get invitation? |
Hi, a bot invites you automatically once your maintainers entry object gets merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally keen on seeing this happen but I don't think a binary distribution is the way for nixpkgs. My 2¢ fwiw.
Btw I had a look at how to compile this on OSX and apparently it requires nodejs (ok), go (ok), and "wails"? some kind of golang library which lets you write osx guis in go & html? It exists in nixpkgs, but currently linux only, which is ironic to say the least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to change my original feedback about compiling from source being preferable on the basis that one of the dependencies for this isn't available for darwin in nixpkgs, it only works on linux. I don't think it's fair to make this PR contingent on fixing that, as well. It would be nice to add a comment, maybe?
"Downloading as binary package for now because compiling from source requires wails, which is currently only available for linux in nixpkgs."
What do y'all think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's old but it still builds and there are no merge conflicts. I just merged this into master locally, built and tested it, and it worked fine.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Description of changes
Tested Compilations
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes