Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbar: init at 2.1.7-beta #209794

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

xbar: init at 2.1.7-beta #209794

wants to merge 2 commits into from

Conversation

r17x
Copy link

@r17x r17x commented Jan 9, 2023

Description of changes

Put the output from any script or program into your macOS Menu Bar (the BitBar reboot)
https://xbarapp.com/

Tested Compilations
1 package added:
xbar (init at 2.1.7-beta)

1 package built:
xbar
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@r17x
Copy link
Author

r17x commented Feb 18, 2024

@Janik-Haag I read from maintainer-list.nix about invitation to the orgs. How to get invitation?

@Janik-Haag
Copy link
Member

Hi, a bot invites you automatically once your maintainers entry object gets merged.
I have no time to review this pr, sorry (the label was added by a bot). You can ask on discourse or matrix for reviews.

Copy link
Member

@hraban hraban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally keen on seeing this happen but I don't think a binary distribution is the way for nixpkgs. My 2¢ fwiw.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/by-name/xb/xbar/package.nix Show resolved Hide resolved
@hraban
Copy link
Member

hraban commented Feb 26, 2024

Btw I had a look at how to compile this on OSX and apparently it requires nodejs (ok), go (ok), and "wails"? some kind of golang library which lets you write osx guis in go & html? It exists in nixpkgs, but currently linux only, which is ironic to say the least.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/by-name/xb/xbar/package.nix Show resolved Hide resolved
pkgs/by-name/xb/xbar/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xb/xbar/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@hraban hraban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to change my original feedback about compiling from source being preferable on the basis that one of the dependencies for this isn't available for darwin in nixpkgs, it only works on linux. I don't think it's fair to make this PR contingent on fixing that, as well. It would be nice to add a comment, maybe?

"Downloading as binary package for now because compiling from source requires wails, which is currently only available for linux in nixpkgs."

What do y'all think?

Copy link
Member

@hraban hraban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's old but it still builds and there are no merge conflicts. I just merged this into master locally, built and tested it, and it worked fine.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants