puredata: upgrade to 0.54-0 and enable darwin

[carlthome]

Description of changes

Upgrade Pure Data to latest and fix Darwin support.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[onny]

Looks great, thank you for this nice work. Could you please add this changelog url to the meta section? https://msp.puredata.info/Pd_documentation/x5.htm#s1

[carlthome]

@onny thanks! Think this is ready to go now. Seems to work fine in sandboxed Darwin at least, in manual testing.

I could manually test on x86 Linux (NixOS desktop) if needed too.

[carlthome]

Any action needed on my part to get this in?

[carlthome]

For anyone on macOS wanting to run Pure Data, feel free to use

nix run github:carlthome/nixpkgs/puredata-darwin#puredata

in the meantime.

[wegank]

Result of nixpkgs-review pr 230569 run on aarch64-linux 1

1 package marked as broken and skipped:

• helmholtz

2 packages failed to build:

• cyclone
• gem

6 packages built:

• maxlib
• mrpeach
• puredata
• puremapping
• timbreid
• zexy

[wegank]

Breaks cyclone and gem, both need to be updated in the same PR.

[carlthome]

Thanks @wegank! When I'm running nixpkgs-review pr 230569 I only see

1 package built:
puredata

on aarch64-darwin so I guess this is particularly about linux. I'll check it out on another machine.

[carlthome]

cyclone cannot compile because it's using private functions from puredata: pure-data/pure-data#2043

[carlthome]

And gem is having

Event.cpp: In function 'void dequeueEvents()':
Event.cpp:353:5: error: 'error' was not declared in this scope; did you mean 'perror'?
  353 |     error("dequeue NULL queue");
      |     ^~~~~
      |     perror
Event.cpp:358:5: error: 'error' was not declared in this scope; did you mean 'perror'?
  358 |     error("dequeue empty queue");
      |     ^~~~~

[carlthome]

Until porres/pd-cyclone#627 is resolved and a patch release exists, I think it's best to mark cyclone as broken since it doesn't compile. Regardless, it would be nice to get out an updated Pure Data version to have it work on Macs. Thoughts?

[magnetophon]

Cyclone has been fixed in their master branch.
For me, everything works when I use:

{ lib, stdenv, fetchFromGitHub, puredata }:

stdenv.mkDerivation rec {
  pname = "cyclone";
  version = "unstable-2023-09-12";

  src = fetchFromGitHub {
    owner = "porres";
    repo = "pd-cyclone";
    rev = "7c470fb03db66057a2198843b635ac3f1abde84d";
    sha256 = "sha256-ixfnmeoRzV0qEOOIxCV1361t3d59fwxjHWhz9uXQ2ps=";
  };

  buildInputs = [ puredata ];

  makeFlags = [
    "pdincludepath=${puredata}/include/pd"
    "prefix=$(out)"
  ];

  postInstall = ''
    mv "$out/lib/pd-externals/cyclone" "$out/"
    rm -rf $out/lib
  '';

  meta = {
    description = "A library of PureData classes, bringing some level of compatibility between Max/MSP and Pd environments";
    homepage = "http://puredata.info/downloads/cyclone";
    license = lib.licenses.tcltk;
    maintainers = [ lib.maintainers.magnetophon ];
    platforms = lib.platforms.linux;
  };
}

[carlthome]

Great news @magnetophon!

[carlthome]

So should we merge this now?

[magnetophon]

Result of nixpkgs-review pr 230569 run on x86_64-linux 1

10 packages built:

• cyclone
• gem
• helmholtz
• magnetophonDSP.VoiceOfFaust
• maxlib
• mrpeach
• puredata
• puremapping
• timbreid
• zexy

Seemed fine, until I tried to test my most important pd patch, the one inside Voice Of Faust.

I got:

verbose(0): osc/packOSC
verbose(1): ... couldn't create
verbose(0): net/udpsend
verbose(1): ... couldn't create
fiddle version 1.1 TEST4
error: /nix/store/6gxvrxaql2kmf4vqmlnjwp0abr8w1nvr-VoiceOfFaust-1.1.4/PureData/helmholtz~.pd_linux:libstdc++.so.6: cannot open shared object file: No such file or directory
verbose(0): helmholtz~
verbose(1): ... couldn't create
verbose(0): net/udpreceive 5511
verbose(1): ... couldn't create
verbose(0): osc/unpackOSC
verbose(1): ... couldn't create
verbose(0): osc/pipelist
verbose(1): ... couldn't create
verbose(0): osc/routeOSC /VoiceOfFaust/OSC/max_pitch /VoiceOfFaust/OSC/min_pitch
verbose(1): ... couldn't create
Terminated

Not sure what causes that, I haven't had time to investigate.

[carlthome]

Not sure what causes that, I haven't had time to investigate.

Hmm, on a skim it looks like there's a newer version of C++ assumed, since libstdc++.so.6: cannot open shared object file: No such file or directory

[carlthome]

Should we merge this anyway or let it sit?

[magnetophon]

Should we merge this anyway or let it sit?

Sorry for the late reply.
Turns out the issue was in my patch.

AFAIK this is good to merge.

[raboof]

I tried the following shell with this branch (nix-shell -I nixpkgs=/path/to/this/pr):

{ pkgs ? import <nixpkgs> {} }:

pkgs.mkShell {
  buildInputs = [
    (pkgs.puredata-with-plugins [ pkgs.gem ])
  ];
}

starting pd -lib Gem gives me Gem: can't load library. On nixos-unstable loading Gem does start, but ultimately fails (citing not being able to load libndi.so.4). I'm not sure that's the same problem, but it makes me reluctant to merge this PR

[carlthome]

Thanks @raboof! I'll look into test running and fixing this when I get to a Linux workstation.

nix develop --impure --expr '{pkgs ? import <nixpkgs> {}, ...}: pkgs.mkShell { buildInputs = [ (pkgs.puredata-with-plugins [ pkgs.gem ]) ]; }'

Hoping it's just a matter of adding libndi to buildInputs.

[wegank]

Result of nixpkgs-review pr 230569 run on aarch64-darwin 1

1 package built:

• puredata

[raboof]

Thanks @raboof! I'll look into test running and fixing this when I get to a Linux workstation.

nix develop --impure --expr '{pkgs ? import <nixpkgs> {}, ...}: pkgs.mkShell { buildInputs = [ (pkgs.puredata-with-plugins [ pkgs.gem ]) ]; }'

Hoping it's just a matter of adding libndi to buildInputs.

Actually the NDI warning was just that, a warning. It seems something changed with the expected values passed to -path, but even with that fixed I'm now getting segmentation faults. Filed #261228 .