Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lomiri.lomiri-terminal-app: init at 2.0.2 #247112

Merged
merged 3 commits into from
Jan 17, 2024
Merged

lomiri.lomiri-terminal-app: init at 2.0.2 #247112

merged 3 commits into from
Jan 17, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Aug 4, 2023 •
edited
Loading

Description of changes

Working towards #99090.

Lomiri Terminal App. Self-explanatory.
image

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from svenkeidel August 4, 2023 12:56
@OPNA2608 OPNA2608 removed the request for review from svenkeidel August 4, 2023 13:00
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Aug 4, 2023

(Un-requested the automatic review request, as the change pertaining to them (libsforQt5.qmltermwidget) has a separate PR)

@OPNA2608 OPNA2608 mentioned this pull request Oct 13, 2023
Open
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from dc9f57d to e7d3260 Compare November 13, 2023 10:59
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from e7d3260 to 2e1a35a Compare November 13, 2023 22:05
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch 2 times, most recently from 9c8f0de to 05f34b2 Compare December 19, 2023 15:54
@OPNA2608

This comment was marked as resolved.

Sign in to view
@OPNA2608 OPNA2608 changed the title lomiri.lomiri-terminal-app: init at 2.0.1 lomiri.lomiri-terminal-app: init at 2.0.2 Dec 19, 2023
@OPNA2608 OPNA2608 mentioned this pull request Dec 19, 2023
Merged
13 tasks
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from 05f34b2 to aa6f4ac Compare December 19, 2023 19:13
@OPNA2608

This comment was marked as resolved.

Sign in to view
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from aa6f4ac to 26aae5e Compare December 20, 2023 00:39
@OPNA2608 OPNA2608 mentioned this pull request Dec 21, 2023
Merged
12 tasks
@OPNA2608 OPNA2608 force-pushed the init/lomiri/lomiri-terminal-app branch from 26aae5e to 6d8373b Compare January 15, 2024 17:49
@OPNA2608 OPNA2608 marked this pull request as ready for review January 15, 2024 17:50
@SuperSandro2000
Copy link
Member

Looking really clean, great work 👍🏼

@SuperSandro2000 SuperSandro2000 merged commit 23a88af into NixOS:master Jan 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OPNA2608 @SuperSandro2000