nixos/teeworlds: add more configuration options #247668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagy
reviewed
Aug 20, 2023
There was a problem hiding this comment.
I like the overall intent of this. But I am a bit torn on whether or not we should track the default values ourselves. This has a chance that they diverge from upstream, but it allows us to use them in some other ways during evaluation.
One thing down in ExecStart you should use cfg.package , now that you have introduced it. For some reason I cannot comment on that line.
nagy
approved these changes
Aug 20, 2023
|
Is it possible for this to get merged by any chance? @SuperSandro2000 @wegank |
13 tasks
SuperSandro2000
approved these changes
Dec 5, 2023
jtbx
force-pushed
the
nixos-teeworlds
branch
from
7bb5099
to
9f7d12d
Compare
- add 'package' option - add 'game' and 'server' attrset - reduce repetition by using functions bool and optionalSetting - add default value for cfg.name - revise some option descriptions
jtbx
force-pushed
the
nixos-teeworlds
branch
from
9f7d12d
to
e01eda6
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added more configuration options to the Teeworlds NixOS module, reduced repetition by adding functions to help generate teeworlds.cfg, fixed some minor mistakes in option descriptions and made "unnamed server" the default value for
name.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)