-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/teeworlds: add more configuration options #247668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the overall intent of this. But I am a bit torn on whether or not we should track the default values ourselves. This has a chance that they diverge from upstream, but it allows us to use them in some other ways during evaluation.
One thing down in ExecStart
you should use cfg.package
, now that you have introduced it. For some reason I cannot comment on that line.
Is it possible for this to get merged by any chance? @SuperSandro2000 @wegank |
7bb5099
to
9f7d12d
Compare
- add 'package' option - add 'game' and 'server' attrset - reduce repetition by using functions bool and optionalSetting - add default value for cfg.name - revise some option descriptions
9f7d12d
to
e01eda6
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1445 |
Description of changes
Added more configuration options to the Teeworlds NixOS module, reduced repetition by adding functions to help generate teeworlds.cfg, fixed some minor mistakes in option descriptions and made "unnamed server" the default value for
name
.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)