Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lomiri.qtmir: init at 0.7.2-unstable-2024-01-08 #259804

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 8, 2023

Description of changes

Working towards #99090.

QtMir (AFAICT) is a Qt Platform Abstraction (QPA) plugin to make Qt a compositor for Mir (as in, the non-Wayland platform). It is used by Lomiri itself to start & communicate with Mir for graphics & desktop interactions.

QtMir only supports Mir 1.x officially. Mir 1.x can be packaged, but it has some problems. Upstream is aiming to convert QtMir from Mir 1.x (a Mir-only server) and MirAL to Mir 2.x (a Wayland compositor framework) and Miroil. We're going to do the same thing Debian has done in their Lomiri effort and package an upstream branch with the Mir 2.x migration instead of going with the regular QtMir. I have thus opted to change the pname and add some comments about this situation.

Upstream tests have not been made Mir 2.x compatible yet, so there's sadly no testing for this. Launching the qtmir-demo-client on top of my Miriway session (I assume any Wayland compositor will do) works, as does the entire Lomiri ecosystem on my WIP branch.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@OPNA2608

This comment was marked as resolved.

@OPNA2608 OPNA2608 force-pushed the init/lomiri/qtmir branch 2 times, most recently from 443de59 to 7924c46 Compare January 1, 2024 13:52
@OPNA2608 OPNA2608 changed the title lomiri.qtmir: init at unstable-2023-02-23 lomiri.qtmir: init at 0.7.1-unstable-2023-06-28 Jan 1, 2024
@OPNA2608 OPNA2608 marked this pull request as ready for review January 1, 2024 14:16
@OPNA2608 OPNA2608 changed the title lomiri.qtmir: init at 0.7.1-unstable-2023-06-28 lomiri.qtmir: init at 0.7.2-unstable-2024-01-08 Jan 8, 2024
@OPNA2608

This comment was marked as resolved.

@OPNA2608 OPNA2608 marked this pull request as draft January 17, 2024 01:13
@OPNA2608 OPNA2608 marked this pull request as ready for review January 18, 2024 00:57
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 259804 run on x86_64-linux 1

2 packages built:
  • lomiri.qtmir
  • lomiri.qtmir.dev

LGTM

@pbsds pbsds merged commit e7120ab into NixOS:master Jan 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants