lomiri.trust-store: init at unstable-2023-10-17 #261919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPNA2608
force-pushed
the
init/lomiri/trust-store
branch
from
167eb6b
to
93fe689
Compare
OPNA2608
force-pushed
the
init/lomiri/trust-store
branch
from
93fe689
to
0e642a4
Compare
OPNA2608
force-pushed
the
init/lomiri/trust-store
branch
from
0e642a4
to
ca55619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Working towards #99090.
trust-store, under Mir 1.x, lets applications spawn a prompt with elevated priority and persists their results. In our Mir 2.x world, it's lacking a Wayland implementation so it can only spawn a new terminal with a
whiplashTUI prompt. Will be used by Lomiri's location service and the security & privacy plugin for the system settings app.I have been unable to get the tests fully working.
dbus_testseems generally busted even on upstream's CI, hanging indefinitely waiting for (I think) some DBus call/signal. The UnixDomainSocket* parts ofremote_agent_testseemingly fail with astd::system_error: Invalid argumenthappening whenboost::asio::writeing to come child process' socket. I don't understand enough C++, Boost, Unix sockets etc to say what the problem is, nor do I have enough spare time to debug this right now.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)They all need very specific arguments to not instantly throw exceptions & exit, builds further down the line can seemingly call them properly though.