-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libayatana-common: Enable Lomiri features #262118
libayatana-common: Enable Lomiri features #262118
Conversation
db7b3dd
to
d89d7aa
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3246 |
|
I found that it was a network proxy problem that caused the dependency download to fail, so I deleted the previous |
Hmm, well I reran
So you can save yourself a |
This comment was marked as resolved.
This comment was marked as resolved.
d89d7aa
to
2e7ed08
Compare
Builds fine again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 262118
run on x86_64-linux 1
1 package built:
- libayatana-common
Description of changes
Working towards #99090.
Enable Lomiri features in
libayatana-common
. This will make even vanilla Ayatana indicators depend on LUD whose GUI tool depends on LUITK, which is not great for closure size:61.4M
->847.9M
. We can introduce alib
output to LUD with only the library, which would solve this and bring it down to61.5M
, but I haven't tested if I moved everything correctly with that change or if something might break somewhere - I needed tomoveToOutput
afew things out oflib
.I plan to revisit this once Lomiri is far enough to build & launch into the DE on master, at which point testing the fallout of that should be easier for me. With nothing outside of Lomiri currently using
libayatana-common
anyway, this shouldn't be a problem for now. I've taken note of this in the Lomiri tracking issue.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)