-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lomiri.morph-browser: init at 1.1.0 #262433
Conversation
7f3e5b4
to
af96f3e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
03cacc0
to
76b0512
Compare
This comment was marked as resolved.
This comment was marked as resolved.
76b0512
to
791f2b7
Compare
For getting proper graphics in testing (normally Lomiri / its NixOS module would set this up): env UITK_ICON_THEME=suru XDG_DATA_DIRS="$(nix-build --no-out-link . -A lomiri.suru-icon-theme)"/share:$XDG_DATA_DIRS "$(nix-build --no-out-link . -A lomiri.morph-browser)"/bin/morph-browser Edit: I also added a VM test to check that the browser
|
fe4c150
to
04e4c0f
Compare
5343939
to
7817619
Compare
Ping @SuperSandro2000, anything else? |
I'm getting a timeout on the nixosTest when merged onto master |
Seems to be an issue with the latest imagemagick bump (#288208), bisected within the
I can confirm via reverting some commits that #289264 had to disable some of its OCR tests due to degraded text recognition with this new version, and that their old tests work fine on the previous version. I'll also adjust the OCR part of the tests here. (Not sure if this is worth escalating to an issue, prolly just a part of dealing with the OCR's moodiness. Just wanted to mention the path I took for figuring this out.) |
7817619
to
eaa50fe
Compare
This comment was marked as resolved.
This comment was marked as resolved.
eaa50fe
to
a8069ff
Compare
I added various UI strings to look for, I hope it's more reliable now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs fine, and the derivation and desktop files LGTM
Description of changes
Working towards #99090.
Morph Browser is the Lomiri web browser. Last time I checked, neither Firefox nor Chrome work under Lomiri (Wayland), so this might be necessary for everyday use.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)