lomiri.telephony-service: init at 0.5.2 #264844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPNA2608
force-pushed
the
init/lomiri/telephony-service
branch
from
32fe083
to
0abe650
Compare
OPNA2608
force-pushed
the
init/lomiri/telephony-service
branch
from
0abe650
to
9f046ac
Compare
OPNA2608
force-pushed
the
init/lomiri/telephony-service
branch
from
7c548bb
to
85ed3a0
Compare
OPNA2608
force-pushed
the
init/lomiri/telephony-service
branch
3 times, most recently
from
573ee09
to
4d06d53
Compare
OPNA2608
force-pushed
the
init/lomiri/telephony-service
branch
from
4d06d53
to
c56d24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Working towards #99090.
telephony-serviceis a dispatcher service for mobile phone related operations. The Lomiri shell and the dialer, address book & messaging app request it.QML tests are disabled due to some issue with phone number formatting. Maybe some assumptions about how
libphonenumberformats certain numbers has changed since they were written? For example, expects+558187042155to be re-formatted as+55 81 8704-2155but it turns into+55 81 87042-155instead.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)