Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sarif-tools: init at 2.0.0 #283208

Merged
merged 2 commits into from
May 12, 2024
Merged

Conversation

puzzlewolf
Copy link
Contributor

Description of changes

Add https://github.com/microsoft/sarif-tools, a collection of tools for working with Static Analysis Results Interchange Format (SARIF) files.

This is a draft because it requires #282347 to fix the failing tests of the python-docx dependency (#282180). I made sure sarif-tools itself is fine by skipping python-docx's tests.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zebreus
Copy link
Contributor

zebreus commented Apr 4, 2024

#282347 is merged, can you rebase this PR against the latest nixpkgs? That should fix the tests.

@zebreus zebreus mentioned this pull request Apr 5, 2024
7 tasks
@puzzlewolf puzzlewolf force-pushed the puzzlewolf/sarif-tools branch 2 times, most recently from cc57f6d to 1a896e1 Compare April 13, 2024 15:44
@puzzlewolf
Copy link
Contributor Author

@zebreus I rebased and added the changelog link, should be ready for review now :)

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sarif-tools/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sarif-tools/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sarif-tools/default.nix Outdated Show resolved Hide resolved
@puzzlewolf
Copy link
Contributor Author

Thanks for the review @AndersonTorres! I applied the changes, should be ready for merging now.

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 283208 run on x86_64-linux 1

4 packages built:
  • sarif-tools (python311Packages.sarif-tools)
  • sarif-tools.dist (python311Packages.sarif-tools.dist)
  • python312Packages.sarif-tools
  • python312Packages.sarif-tools.dist

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work!

Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
@Aleksanaa Aleksanaa merged commit db4171f into NixOS:master May 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants