nixos/garage: allow all available log levels in cfg.logLevel
#288637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`error` and `warn` have always been valid log levels. But because the upstream docs never mentioned those, we simply didn't add them to the enum of our module option. The upstream docs have been updated and now mention `error` and `warn` as well. Upstream PR: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/716
RaitoBezarius
approved these changes
Feb 14, 2024
Merged
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
errorandwarnhave always been valid log levels. But because the upstream docs never mentioned those, we simply didn't add them to the enum of our module option.The upstream docs have been updated and now mention
errorandwarnas well.Upstream PR: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/716
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)