Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/plasma6: move out of x11 #292141

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

SuperSandro2000
Copy link
Member

This release focuses on wayland, lets give that justice

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@rsniezek rsniezek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a sentence or two in the commit msg about how are you giving it a justice?

@SuperSandro2000
Copy link
Member Author

Could you add a sentence or two in the commit msg about how are you giving it a justice?

By moving the options from services.xserver.desktopManager.plasma6 to services.desktopManager.plasma6.

@nyabinary
Copy link
Contributor

Could you add a sentence or two in the commit msg about how are you giving it a justice?

By moving the options from services.xserver.desktopManager.plasma6 to services.desktopManager.plasma6.

TBH, I would be all for moving everything that supports Wayland out of the xservice/x11 directory, where would Wayland-only DE go, though? E.g. COSMIC?

@SuperSandro2000
Copy link
Member Author

TBH, I would be all for moving everything that supports Wayland out of the xservice/x11 directory, where would Wayland-only DE go, though? E.g. COSMIC?

Yes but let's start somewhere and then go from there to the other bits.

We just strip xserver from the options path. Then the options don't mention a specific display technology.

@pbek
Copy link
Contributor

pbek commented Mar 7, 2024

Will it still be possible to use Plasma6 with X11? The Nvidia Wayland Plasma6 support still was mostly broken in all my tests. Especially with old Nvidia graphic cards or with 4k single or dual screen (but I wasn't even able to make the latter work even with X11).

@K900
Copy link
Contributor

K900 commented Mar 7, 2024

Yes.

@pbek
Copy link
Contributor

pbek commented Mar 7, 2024

Awesome. I had 0 issues with AMD Radeon or Intel graphic cards. But Nvidia... phew... 😅 No suspend to RAM without garbled characters, no screen-lock without only getting a black screen afterward (the latter also under X11).

@michaelBelsanti
Copy link
Contributor

It would be great to have this merged before the Cosmic module, so we can avoid having to move that one in the future

Copy link
Contributor

@Shawn8901 Shawn8901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i use that pr since some days on my fork, i like the idea of moving the desktop managers out of the xserver config namespace, as the major ones are pushing to wayland (only) sessions, so it might be a good idea to unrelate it in our config as well

This release focuses on wayland, lets give that justice
@SuperSandro2000 SuperSandro2000 merged commit e220724 into NixOS:master Mar 12, 2024
20 checks passed
@SuperSandro2000 SuperSandro2000 deleted the plasma-out-xserver branch March 12, 2024 12:55
@SuperSandro2000
Copy link
Member Author

If you encounter any issues, please give me an @.

Also the people that tested this: please chime into #291913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants