gimpPlugins.gap: patch ffmpeg to avoid asm error #295257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 2 packages built:
|
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3650 |
| @@ -123,6 +123,23 @@ in | |||
|
|
|||
| nativeBuildInputs = with pkgs; [autoreconfHook]; | |||
|
|
|||
| postUnpack = '' | |||
There was a problem hiding this comment.
Can't we unvendor ffmpeg?
There was a problem hiding this comment.
I haven't tried yet. The version that's being used by gap is more than a decade old
Edit: I also thought we should add at least a handful of ffmpeg CVEs to this package because of that :/
|
Result of 2 packages built:
|
trofi
approved these changes
Apr 13, 2024
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
force-pushed
the
pkgs/gimp-plugin-gap/fix-build-2
branch
from
cca25fd
to
2601357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #294707
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.