-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fzf: 0.47.0 -> 0.48.1 #295978
fzf: 0.47.0 -> 0.48.1 #295978
Conversation
Builds in general and works but will break shell-completion for all platform (see changelog) Result of 48 packages built:
Not fully certain but it appears to be common to move the loading to the module as it requires eval in the users-config now? |
Result of 1 package marked as broken and skipped:
40 packages built:
|
ℹ️ In the meantime fzf 0.48.1 has been released. Is there a way for @r-ryantm to pick this up automatically in this PR or will another PR be created? |
Not sure about that but I would assume it creates another one. I can create a new one containing 0.48.1 and the fix for the module removing shell-completion install from the derivation itself if you agree that's the way to go-ahead? |
@SebTM can you provide more context about and pointers to the removal of the shell completion module? Maybe other PRs that have done so or a README in this repository documenting best practices? That would be helpful for me. |
https://github.com/junegunn/fzf/releases/tag/0.48.0 After seeing that change I checked nixpkgs how other packages using eval to load do that (piping the val to a file to keep behavior or do it by module)
nixpkgs/nixos/modules/programs/direnv.nix Line 72 in 03cce56
so I assumed that could be the preferred way |
Thanks for the helpful context, @SebTM, much appreciated. Since I'm using nixpkgs on aarch64-darwin I cannot speak on nixos modules, but am wondering whether this is or will be exposed via home-manager or other means to nixpkgs 🤔 |
fzf I would say the changes need to be done to both modules |
Looks like it will neither update this PR nor create a new one while this is open: https://r.ryantm.com/log/fzf/2024-03-18.log |
@SebTM would you be interested in creating a new PR that supersedes this one and includes the various changes that were talked about here? |
I can if nobody want's / does it until the weekend before I might not get to it... |
e68272d
to
2d8947d
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/fzf/versions. meta.description for fzf is: A command-line fuzzy finder written in Go meta.homepage for fzf is: https://github.com/junegunn/fzf meta.changelog for fzf is: https://github.com/junegunn/fzf/blob/0.48.1/CHANGELOG.md Updates performed
To inspect upstream changesImpactChecks done
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 50 packages built:
Maintainer pingscc @Br1ght0ne @Ma27 @zowoq for testing. |
Superseeded by #298692 |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/junegunn/fzf/releases.
meta.description for fzf is: A command-line fuzzy finder written in Go
meta.homepage for fzf is: https://github.com/junegunn/fzf
meta.changelog for fzf is: https://github.com/junegunn/fzf/blob/0.48.0/CHANGELOG.md
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }'
run on x86_64-linux 150 packages built:
Maintainer pings
cc @Br1ght0ne @Ma27 @zowoq for testing.