fzf: 0.47.0 -> 0.48.1 #295978

r-ryantm · 2024-03-14T21:00:34Z

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/junegunn/fzf/releases.

meta.description for fzf is: A command-line fuzzy finder written in Go

meta.homepage for fzf is: https://github.com/junegunn/fzf

meta.changelog for fzf is: https://github.com/junegunn/fzf/blob/0.48.0/CHANGELOG.md

Updates performed

Golang update

To inspect upstream changes

Impact

Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.48.0 with grep in /nix/store/qazhdjwfpi6y6j0zqawnhsca0mvgfkz8-fzf-0.48.0
found 0.48.0 in filename of file in /nix/store/qazhdjwfpi6y6j0zqawnhsca0mvgfkz8-fzf-0.48.0

Rebuild report (if merged into master) (click to expand)

42 total rebuild path(s)

42 package rebuild(s)

First fifty rebuilds by attrpath
adl
ani-cli
arsenal
catcli
clerk
felix-fm
fishPlugins.fzf-fish
fontpreview
fzf
fzf-git-sh
fzf-zsh
kakounePlugins.fzf-kak
kns
license-cli
lunarvim
mov-cli
navi
python311Packages.pyfzf
python312Packages.pyfzf
ripgrep-all
spacevim
sway-launcher-desktop
sysz
tmuxPlugins.extrakto
tmuxPlugins.fuzzback
tmuxPlugins.session-wizard
tmuxPlugins.t-smart-tmux-session-manager
tmuxPlugins.tmux-fzf
unipicker
vimPlugins.fzf-hoogle-vim
vimPlugins.fzf-lua
vimPlugins.fzf-vim
vimPlugins.fzfWrapper
vimPlugins.telescope-zoxide
vimPlugins.vim-fzf-coauthorship
vimPlugins.vim-zettel
vimPlugins.zoxide-vim
xmloscopy
yazi
ytfzf
zoxide
zsh-forgit

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/qazhdjwfpi6y6j0zqawnhsca0mvgfkz8-fzf-0.48.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A fzf https://github.com/r-ryantm/nixpkgs/archive/e68272d5ed965712ebb836709f3be72e8f069c77.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/e68272d5ed965712ebb836709f3be72e8f069c77#fzf

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/qazhdjwfpi6y6j0zqawnhsca0mvgfkz8-fzf-0.48.0
ls -la /nix/store/qazhdjwfpi6y6j0zqawnhsca0mvgfkz8-fzf-0.48.0/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

50 packages built:

adl
ani-cli
arsenal
arsenal.dist
catcli
catcli.dist
clerk
felix-fm
fishPlugins.fzf-fish
fontpreview
fzf
fzf-git-sh
fzf-zsh
fzf.man
kakounePlugins.fzf-kak
kns
license-cli
lunarvim
mov-cli
mov-cli.dist
navi
ocamlPackages.fzf
ocamlPackages.magic-trace
python311Packages.pyfzf
python311Packages.pyfzf.dist
python312Packages.pyfzf
python312Packages.pyfzf.dist
ripgrep-all
spacevim
sway-launcher-desktop
sysz
tmuxPlugins.extrakto
tmuxPlugins.fuzzback
tmuxPlugins.session-wizard
tmuxPlugins.t-smart-tmux-session-manager
tmuxPlugins.tmux-fzf
unipicker
vimPlugins.fzf-hoogle-vim
vimPlugins.fzf-lua
vimPlugins.fzf-vim
vimPlugins.fzfWrapper
vimPlugins.telescope-zoxide
vimPlugins.vim-fzf-coauthorship
vimPlugins.vim-zettel
vimPlugins.zoxide-vim
xmloscopy
yazi
ytfzf
zoxide
zsh-forgit

Maintainer pings

cc @Br1ght0ne @Ma27 @zowoq for testing.

SebTM · 2024-03-16T23:13:32Z

Builds in general and works but will break shell-completion for all platform (see changelog)

Result of nixpkgs-review pr 295978 run on x86_64-linux 1

48 packages built:

adl
ani-cli
arsenal
arsenal.dist
catcli
catcli.dist
clerk
felix-fm
fishPlugins.fzf-fish
fontpreview
fzf
fzf-git-sh
fzf-zsh
fzf.man
kakounePlugins.fzf-kak
kns
license-cli
lunarvim
mov-cli
mov-cli.dist
navi
python311Packages.pyfzf
python311Packages.pyfzf.dist
python312Packages.pyfzf
python312Packages.pyfzf.dist
ripgrep-all
spacevim
sway-launcher-desktop
sysz
tmuxPlugins.extrakto
tmuxPlugins.fuzzback
tmuxPlugins.session-wizard
tmuxPlugins.t-smart-tmux-session-manager
tmuxPlugins.tmux-fzf
unipicker
vimPlugins.fzf-hoogle-vim
vimPlugins.fzf-lua
vimPlugins.fzf-vim
vimPlugins.fzfWrapper
vimPlugins.telescope-zoxide
vimPlugins.vim-fzf-coauthorship
vimPlugins.vim-zettel
vimPlugins.zoxide-vim
xmloscopy
yazi
ytfzf
zoxide
zsh-forgit

Not fully certain but it appears to be common to move the loading to the module as it requires eval in the users-config now?

afh · 2024-03-17T07:38:19Z

Result of nixpkgs-review pr 295978 run on aarch64-darwin 1

1 package marked as broken and skipped:

fontpreview

40 packages built:

ani-cli
arsenal
arsenal.dist
catcli
catcli.dist
felix-fm
fzf
fzf-git-sh
fzf-zsh
fzf.man
license-cli
lunarvim
mov-cli
mov-cli.dist
navi
python311Packages.pyfzf
python311Packages.pyfzf.dist
python312Packages.pyfzf
python312Packages.pyfzf.dist
ripgrep-all
spacevim
sysz
tmuxPlugins.extrakto
tmuxPlugins.fuzzback
tmuxPlugins.session-wizard
tmuxPlugins.tmux-fzf
unipicker
vimPlugins.fzf-hoogle-vim
vimPlugins.fzf-lua
vimPlugins.fzf-vim
vimPlugins.fzfWrapper
vimPlugins.telescope-zoxide
vimPlugins.vim-fzf-coauthorship
vimPlugins.vim-zettel
vimPlugins.zoxide-vim
xmloscopy
yazi
ytfzf
zoxide
zsh-forgit

afh · 2024-03-17T11:18:22Z

ℹ️ In the meantime fzf 0.48.1 has been released. Is there a way for @r-ryantm to pick this up automatically in this PR or will another PR be created?

SebTM · 2024-03-17T11:22:09Z

Not sure about that but I would assume it creates another one. I can create a new one containing 0.48.1 and the fix for the module removing shell-completion install from the derivation itself if you agree that's the way to go-ahead?

afh · 2024-03-17T12:41:53Z

@SebTM can you provide more context about and pointers to the removal of the shell completion module? Maybe other PRs that have done so or a README in this repository documenting best practices? That would be helpful for me.

SebTM · 2024-03-17T12:47:34Z

@SebTM can you provide more context about and pointers to the removal of the shell completion module? Maybe other PRs that have done so or a README in this repository documenting best practices? That would be helpful for me.

https://github.com/junegunn/fzf/releases/tag/0.48.0
https://github.com/junegunn/fzf/blob/0.48.0/CHANGELOG.md

After seeing that change I checked nixpkgs how other packages using eval to load do that (piping the val to a file to keep behavior or do it by module)

nixpkgs/nixos/modules/programs/zsh/zsh.nix

Line 68 in 03cce56

Shell script code called during zsh shell initialisation.

nixpkgs/nixos/modules/programs/thefuck.nix

Line 10 in 03cce56

eval $(${pkgs.thefuck}/bin/thefuck --alias ${cfg.alias})

nixpkgs/nixos/modules/programs/direnv.nix

Line 72 in 03cce56

eval "$(${lib.getExe cfg.package} hook zsh)"

so I assumed that could be the preferred way

afh · 2024-03-17T16:20:24Z

Thanks for the helpful context, @SebTM, much appreciated. Since I'm using nixpkgs on aarch64-darwin I cannot speak on nixos modules, but am wondering whether this is or will be exposed via home-manager or other means to nixpkgs 🤔

SebTM · 2024-03-17T16:43:59Z

fzf
https://github.com/nix-community/home-manager/blob/master/modules/programs/fzf.nix#L20

I would say the changes need to be done to both modules

sdht0 · 2024-03-19T00:07:16Z

ℹ️ In the meantime fzf 0.48.1 has been released. Is there a way for @r-ryantm to pick this up automatically in this PR or will another PR be created?

Looks like it will neither update this PR nor create a new one while this is open: https://r.ryantm.com/log/fzf/2024-03-18.log

afh · 2024-03-20T06:07:59Z

@SebTM would you be interested in creating a new PR that supersedes this one and includes the various changes that were talked about here?

SebTM · 2024-03-20T18:41:11Z

@SebTM would you be interested in creating a new PR that supersedes this one and includes the various changes that were talked about here?

I can if nobody want's / does it until the weekend before I might not get to it...

r-ryantm · 2024-03-21T17:56:56Z

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/fzf/versions.

meta.description for fzf is: A command-line fuzzy finder written in Go

meta.homepage for fzf is: https://github.com/junegunn/fzf

meta.changelog for fzf is: https://github.com/junegunn/fzf/blob/0.48.1/CHANGELOG.md

Updates performed

Golang update

To inspect upstream changes

Impact

Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.48.1 with grep in /nix/store/45p2n2dml8v1xvd6wmyjnzwhr8b4gg9r-fzf-0.48.1
found 0.48.1 in filename of file in /nix/store/45p2n2dml8v1xvd6wmyjnzwhr8b4gg9r-fzf-0.48.1

Rebuild report (if merged into master) (click to expand)

42 total rebuild path(s)

42 package rebuild(s)

First fifty rebuilds by attrpath
adl
ani-cli
arsenal
catcli
clerk
felix-fm
fishPlugins.fzf-fish
fontpreview
fzf
fzf-git-sh
fzf-zsh
kakounePlugins.fzf-kak
kns
license-cli
lunarvim
mov-cli
navi
python311Packages.pyfzf
python312Packages.pyfzf
ripgrep-all
spacevim
sway-launcher-desktop
sysz
tmuxPlugins.extrakto
tmuxPlugins.fuzzback
tmuxPlugins.session-wizard
tmuxPlugins.t-smart-tmux-session-manager
tmuxPlugins.tmux-fzf
unipicker
vimPlugins.fzf-hoogle-vim
vimPlugins.fzf-lua
vimPlugins.fzf-vim
vimPlugins.fzfWrapper
vimPlugins.telescope-zoxide
vimPlugins.vim-fzf-coauthorship
vimPlugins.vim-zettel
vimPlugins.zoxide-vim
xmloscopy
yazi
ytfzf
zoxide
zsh-forgit

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/45p2n2dml8v1xvd6wmyjnzwhr8b4gg9r-fzf-0.48.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A fzf https://github.com/r-ryantm/nixpkgs/archive/2d8947d45957fb80a637427911dfdbf7d0eeb5d7.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/2d8947d45957fb80a637427911dfdbf7d0eeb5d7#fzf

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/45p2n2dml8v1xvd6wmyjnzwhr8b4gg9r-fzf-0.48.1
ls -la /nix/store/45p2n2dml8v1xvd6wmyjnzwhr8b4gg9r-fzf-0.48.1/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

50 packages built:

adl
ani-cli
arsenal
arsenal.dist
catcli
catcli.dist
clerk
felix-fm
fishPlugins.fzf-fish
fontpreview
fzf
fzf-git-sh
fzf-zsh
fzf.man
kakounePlugins.fzf-kak
kns
license-cli
lunarvim
mov-cli
mov-cli.dist
navi
ocamlPackages.fzf
ocamlPackages.magic-trace
python311Packages.pyfzf
python311Packages.pyfzf.dist
python312Packages.pyfzf
python312Packages.pyfzf.dist
ripgrep-all
spacevim
sway-launcher-desktop
sysz
tmuxPlugins.extrakto
tmuxPlugins.fuzzback
tmuxPlugins.session-wizard
tmuxPlugins.t-smart-tmux-session-manager
tmuxPlugins.tmux-fzf
unipicker
vimPlugins.fzf-hoogle-vim
vimPlugins.fzf-lua
vimPlugins.fzf-vim
vimPlugins.fzfWrapper
vimPlugins.telescope-zoxide
vimPlugins.vim-fzf-coauthorship
vimPlugins.vim-zettel
vimPlugins.zoxide-vim
xmloscopy
yazi
ytfzf
zoxide
zsh-forgit

Maintainer pings

cc @Br1ght0ne @Ma27 @zowoq for testing.

SebTM · 2024-03-24T17:30:48Z

Superseeded by #298692

ofborg bot requested review from zowoq, Br1ght0ne and Ma27 March 14, 2024 21:37

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Mar 14, 2024

kachick mentioned this pull request Mar 18, 2024

Effectively use fzf kachick/dotfiles#248

Closed

fzf: 0.47.0 -> 0.48.1

2d8947d

r-ryantm changed the title ~~fzf: 0.47.0 -> 0.48.0~~ fzf: 0.47.0 -> 0.48.1 Mar 21, 2024

r-ryantm force-pushed the auto-update/fzf branch from e68272d to 2d8947d Compare March 21, 2024 17:56

SebTM mentioned this pull request Mar 24, 2024

fzf: 0.47.0 -> 0.49.0 #298692

Merged

13 tasks

SebTM closed this Mar 24, 2024

r-ryantm deleted the auto-update/fzf branch March 25, 2024 00:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fzf: 0.47.0 -> 0.48.1 #295978

fzf: 0.47.0 -> 0.48.1 #295978

r-ryantm commented Mar 14, 2024

SebTM commented Mar 16, 2024

afh commented Mar 17, 2024

afh commented Mar 17, 2024

SebTM commented Mar 17, 2024

afh commented Mar 17, 2024

SebTM commented Mar 17, 2024 •

edited

Loading

afh commented Mar 17, 2024

SebTM commented Mar 17, 2024

sdht0 commented Mar 19, 2024

afh commented Mar 20, 2024

SebTM commented Mar 20, 2024

r-ryantm commented Mar 21, 2024

SebTM commented Mar 24, 2024

fzf: 0.47.0 -> 0.48.1 #295978

fzf: 0.47.0 -> 0.48.1 #295978

Conversation

r-ryantm commented Mar 14, 2024

Updates performed

To inspect upstream changes

Impact

Pre-merge build results

Maintainer pings

SebTM commented Mar 16, 2024

afh commented Mar 17, 2024

afh commented Mar 17, 2024

SebTM commented Mar 17, 2024

afh commented Mar 17, 2024

SebTM commented Mar 17, 2024 • edited Loading

afh commented Mar 17, 2024

SebTM commented Mar 17, 2024

sdht0 commented Mar 19, 2024

afh commented Mar 20, 2024

SebTM commented Mar 20, 2024

r-ryantm commented Mar 21, 2024

Updates performed

To inspect upstream changes

Impact

Pre-merge build results

Maintainer pings

SebTM commented Mar 24, 2024

SebTM commented Mar 17, 2024 •

edited

Loading