Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the conda package manager #296461
Add the conda package manager #296461
Changes from all commits
50b4051
9032d72
b948946
1335025
e3ab5cc
14d5b95
f4ab775
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I specifically asked the author to use
python3Packages.python
.The motivation is that we'd be forced to use
python3Packages
instead ofpython3
if we later had to add some python packages as dependencies in order to keep splicing working and avoid bringing diverging versions of the interpreter into the closure. So, might as well always ask forpython3Packages
for consistencyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we merge this as is. If you want this changed to
python3
I suggest we open a separate PR and discuss it thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we you are worried about using different python package sets, then use python3.pkgs instead of python3Packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No,
python3.pkgs
breaks splicing. I think what we need instead is #296461 (comment)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you walk us through the patch? When is
context.dev
true? Is the difference that upstream sets a cleanPYTHONPATH
that only refers to the conda environment and your patch propagates the dependencies of theconda
script itself (sys.path
)? Why was that required?